Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subject relations #672

Merged
merged 9 commits into from
Jun 7, 2024
Merged

Conversation

everpcpc
Copy link
Contributor

@everpcpc everpcpc commented Jun 7, 2024

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 96.34703% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.49%. Comparing base (7231de9) to head (27c5c3b).
Report is 115 commits behind head on master.

Files Patch % Lines
lib/graphql/types/subject.ts 95.03% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   81.98%   79.49%   -2.50%     
==========================================
  Files          69       76       +7     
  Lines        8554     9451     +897     
  Branches      405      424      +19     
==========================================
+ Hits         7013     7513     +500     
- Misses       1536     1933     +397     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trim21
Copy link
Contributor

trim21 commented Jun 7, 2024

这个会造成 N+1 query 吧...

@everpcpc
Copy link
Contributor Author

everpcpc commented Jun 7, 2024

hmmm,graphql 不就是这个样子的吗

@trim21
Copy link
Contributor

trim21 commented Jun 7, 2024

hmmm,graphql 不就是这个样子的吗

我意思是可以加在SubjectByIDQuery上面,感觉没必要加在Subject上?

lib/graphql/types/subject.ts Outdated Show resolved Hide resolved
lib/server.ts Show resolved Hide resolved
@trim21
Copy link
Contributor

trim21 commented Jun 7, 2024

写点测试

@trim21 trim21 merged commit 57e7ef6 into bangumi:master Jun 7, 2024
5 of 6 checks passed
@everpcpc everpcpc deleted the feat-subject-relation branch June 7, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants