This repository has been archived by the owner on Nov 18, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Bump ipfs-http-client from 48.1.1 to 49.0.1 #951
Closed
dependabot
wants to merge
3
commits into
master
from
dependabot/npm_and_yarn/ipfs-http-client-49.0.1
Closed
Bump ipfs-http-client from 48.1.1 to 49.0.1 #951
dependabot
wants to merge
3
commits into
master
from
dependabot/npm_and_yarn/ipfs-http-client-49.0.1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2c89d2
to
7bb928d
Compare
Bumps [ipfs-http-client](https://github.com/ipfs/js-ipfs) from 48.1.1 to 49.0.1. - [Release notes](https://github.com/ipfs/js-ipfs/releases) - [Changelog](https://github.com/ipfs/js-ipfs/blob/master/CHANGELOG.md) - [Commits](https://github.com/ipfs/js-ipfs/compare/[email protected]@49.0.1) Signed-off-by: dependabot[bot] <[email protected]>
7bb928d
to
5f983f2
Compare
RanCohenn
reviewed
Feb 7, 2021
@@ -571,15 +571,22 @@ export class EthereumGovernance extends VuexModule.With({ | |||
|
|||
let metadata; | |||
|
|||
for await (const file of ipfs.get(hash, { | |||
for await (const f of ipfs.get(hash, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done because TypeScript doesn't support Explicit type in a "for..of loop"
microsoft/TypeScript#3500
RanCohenn
reviewed
Feb 7, 2021
timeout: timeoutInSeconds * 1000 | ||
})) { | ||
const file: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done because the docs (although slightly wrong with an extra <>) show this
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps ipfs-http-client from 48.1.1 to 49.0.1.
Release notes
Sourced from ipfs-http-client's releases.
... (truncated)
Commits
10fc290
chore: publish53399d6
chore: do not update example deps during canary publishe1f1374
chore: build bundle during prepublishOnly phase8daa153
chore: update libp2p versiond2632ff
chore: build bundle separate from types91df292
chore: publisheaf5a28
chore: update contributors1eb37be
chore: fix githead version061d77c
chore: update deps (#3514)7e188f2
fix: run the update example deps script in master and not in ci (#3515)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)