Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): allow horizontal scrolling in threads table #168

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

annepinson
Copy link
Contributor

@annepinson annepinson commented Nov 2, 2023

Fix

Currently it is not possible to scroll horizontally in the Threads table of the CPU Usage per thread section.

This PR aims at allowing this horizontal scroll:
Capture d’écran 2023-11-02 à 15 13 54

Feat

This PR also adds a vertical scroll in order to avoid having the threads table taking the whole page.
Capture d’écran 2023-11-02 à 16 37 26

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for flashlight-docs canceled.

Name Link
🔨 Latest commit 4ed6270
🔍 Latest deploy log https://app.netlify.com/sites/flashlight-docs/deploys/6543c1e84ef929000889c96a

@annepbam annepbam force-pushed the report-table-horizontal-scroll branch from afd6094 to 44f3e82 Compare November 2, 2023 14:25
Copy link

github-actions bot commented Nov 2, 2023

Flashlight iOS Report 🔦

@flashlight-bot
Copy link
Contributor

Flashlight Automated Report 🔦

@flashlight-bot
Copy link
Contributor

Flashlight Automated Report 🔦

Copy link
Member

@Almouro Almouro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the fix! ❤️
Much better now

@Almouro Almouro merged commit 0136567 into main Nov 3, 2023
7 checks passed
@Almouro Almouro deleted the report-table-horizontal-scroll branch November 3, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants