Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for PHP 5.5.9+ #55

Merged
merged 3 commits into from
May 3, 2020
Merged

Restore support for PHP 5.5.9+ #55

merged 3 commits into from
May 3, 2020

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented May 2, 2020

phpdotenv is used by millions of people and needs to continue to be tested, since it's still used on PHP 5.5 by Laravel 5.5 LTS users.


Travis will pass ONLY after this PR is merged, because dev-master is being downloaded.

@GrahamCampbell
Copy link
Contributor Author

The answer to the question "why can't you just use the older version of this package" is because composer 1 will stop working all together at some point (probably later this year, actually), and so I need to use composer 2, which only version 1.4 of this package supports.

@theofidry theofidry merged commit 9329fb0 into bamarni:master May 3, 2020
@theofidry
Copy link
Collaborator

Thanks for the PR @GrahamCampbell.

I'm not a big fan of expanding an already quite large array of PHP versions, but it is what it is so let's go with it.

@GrahamCampbell GrahamCampbell deleted the patch-1 branch May 3, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants