Add debug logs #32
Merged
Add debug logs #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamarni
reviewed
Dec 4, 2017
src/BinCommand.php
Outdated
| @@ -132,7 +135,7 @@ private function resetComposers(ComposerApplication $application) | |||
| private function chdir($dir) | |||
| { | |||
| chdir($dir); | |||
| $this->getIO()->writeError('<info>Changed current directory to ' . $dir . '</info>'); | |||
| $this->getIO()->write('<info>Changed current directory to ' . $dir . '</info>', true, IOInterface::VERBOSE); | |||
There was a problem hiding this comment.
it's not an error is it?
There was a problem hiding this comment.
stderr is not limited to errors, it should also be used for diagnostic / debug output. I think this is also what composer / symfony recommend (cf. symfony/symfony#18744 (comment) for example).
There was a problem hiding this comment.
Oh I see, well I learned something today! Thanks for the link I'll update the PR shortly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change but I find that useful and in insight would have made it easier for #23