Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify workflow #101

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Simplify workflow #101

merged 2 commits into from
Jul 8, 2022

Conversation

theofidry
Copy link
Collaborator

@theofidry theofidry commented Jul 8, 2022 •
edited
Loading

With the introducing of end-to-end tests, I do not feel it is needed anymore to use the plugin on itself for PHPUnit. Since using the plugin on itself actually comes with a non-negligible cost:

  • the CI is a bit more complex
  • when developing on the project you need to install the plugin globally (not ideal)

@theofidry theofidry merged commit 6512428 into bamarni:master Jul 8, 2022
@theofidry theofidry deleted the feature/global-plugin branch July 8, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theofidry