Skip to content

Migrate from travis-ci.org to travis-ci.com until 2020-12-31 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christiansiegel opened this issue Nov 30, 2020 · 2 comments · Fixed by #71 or col-panic/rocket-chat-rest-client#1
Closed

Migrate from travis-ci.org to travis-ci.com until 2020-12-31 #63

christiansiegel opened this issue Nov 30, 2020 · 2 comments · Fixed by #71 or col-panic/rocket-chat-rest-client#1
Assignees
@kullmanp
Labels
help wanted

Comments

@christiansiegel
Copy link
Member

travis-ci.org will be closed down December 31st, 2020

Announcement: https://mailchi.mp/3d439eeb1098/travis-ciorg-is-moving-to-travis-cicom
Migration guide: https://docs.travis-ci.com/user/migrate/open-source-repository-migration
@christiansiegel christiansiegel mentioned this issue Nov 30, 2020
Closed
@kullmanp
Copy link
Member

kullmanp commented Apr 8, 2021

Should we archive this project anyway?

@kullmanp kullmanp mentioned this issue Jun 3, 2021
Closed
@kullmanp
Copy link
Member

kullmanp commented Jun 3, 2021

The project is now migrated to travis-ci.com. But the master branch does not build (and it didn't build for some time already). The PR #69 restores a working build by running the integration tests against an older version of rocket.chat.

It would be great if we could test against the latest version. But right now it doesn't work because of issues like RocketChat/Rocket.Chat#19537. In a nutshell: our node version is too old for the current rocket chat versions.

Using a matching node installation requires a bit of change in the build setup. Currently we use rocketchat/base:12.16 as the base for a custom docker image. There is no newer version of the base image with a suitable version of node. I see two options:

  • Update the node version in the Dockerfile (include something like apt install node ...)
  • Instead of the custom image we could use the ready-made rocketchat/rocket.chat:latest image and move all configuration in the Dockerfile to the pom.

kullmanp added a commit to kullmanp/rocket-chat-rest-client that referenced this issue Jun 6, 2021
@kullmanp
Fix build
737940b 
The current build fails because the docker image used for integration tests
has an old version of node. The base image we were using appears not to be
maintained anymore. There is no version with a newer node installation.

This change uses the ready-made docker image rocketchat/rocket.chat:latest  for
the rocket chat server and moves all necessary configuration from the Dockerfile
to the pom.

Fixes baloise#63
@kullmanp kullmanp mentioned this issue Jun 6, 2021
Merged
col-panic pushed a commit that referenced this issue Jun 7, 2021
@kullmanp
Fix build (#71)
0c775dc 
The current build fails because the docker image used for integration tests
has an old version of node. The base image we were using appears not to be
maintained anymore. There is no version with a newer node installation.

This change uses the ready-made docker image rocketchat/rocket.chat:latest  for
the rocket chat server and moves all necessary configuration from the Dockerfile
to the pom.

Fixes #63
@col-panic col-panic mentioned this issue Jun 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kullmanp kullmanp

Labels
help wanted
Projects
None yet
Milestone
No milestone
3 participants
@MarkusTiede @kullmanp @christiansiegel