chore: update links #4225
Open
chore: update links #4225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
May 17, 2024
| @@ -43,10 +43,10 @@ Etcher requires an available [polkit authentication agent](https://wiki.archlinu | |||
|
|
|||
| ## May I run Etcher in older macOS versions? | |||
|
|
|||
| Etcher GUI is based on the [Electron](http://electron.atom.io/) framework, [which only supports macOS 10.10 and newer versions](https://github.com/electron/electron/blob/master/docs/tutorial/support.md#supported-platforms). | |||
| Etcher GUI is based on the [Electron](https://www.electronjs.org/) framework, [which only supports macOS 10.10 and newer versions](https://github.com/electron/electron/blob/main/README.md#platform-support). | |||
There was a problem hiding this comment.
That link says "macOS (Catalina and up)" and https://en.wikipedia.org/wiki/MacOS_Catalina says that this is macOS 10.15 ?
There was a problem hiding this comment.
I just updated the link and did not verify every text. When the faq was written the macOS 10.10 was the current state. The previous link points to the master-branch so it is not clear for which electron it was the case. Maybe remove the explicit macOS version and just keep the reference to electron?
lurch
reviewed
May 17, 2024
Change-type: patch change to https if available some urls changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
change to https if available
some urls changed