-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Core adapter logos and title to keep them uniform #7328
base: master
Are you sure you want to change the base?
Conversation
Thanks for submitting this pull request, @dushmanta05! We'll look at it ASAP. In the mean time, here are some ways you can help speed things along:
Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly. For help with questions about Sails, click here. |
Hey @DominusKelvin! |
Oh hey again, @dushmanta05. Now that this pull request is reopened, it's on our radar. Please let us know if there's any new information we should be aware of! Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly. For help with questions about Sails, click here. |
<a target="_blank" href="http://www.postgresql.org/"><img width="50" title="PostgreSQL" src="http://i.imgur.com/OSlDDKv.png"/></a> | ||
<a target="_blank" href="http://www.mongodb.org/"><img width="100" title="MongoDB" src="http://i.imgur.com/bC2j13z.png"/></a> | ||
<a target="_blank" href="http://redis.io/"><img width="75" title="Redis" src="http://i.imgur.com/dozv0ub.jpg"/></a> | ||
<a target="_blank" href="http://www.mysql.com/"><img width="55" title="MySQL" src="https://cdn.jsdelivr.net/gh/devicons/devicon@latest/icons/mysql/mysql-original-wordmark.svg" alt="MySQL"/></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @dushmanta05
Good PR 👍
The changes are misleading as the PR title meant to update only logo URLs. But, the content is changed.
I noticed the MySQL is changed from
alt="Powered by MySQL" title="sails-mysql: MySQL adapter for Sails"
to
alt="MySQL" title="MySQL"
Either change PR title to match the changes or Refactor the changes to match PR title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I changed the title to make it uniform with other logos and titles; I'll update it in the PR title. Thanks again.
Updated the core adapter logos and titles in README to make them uniform.
It was looking something like this:
So changed the width height and logo URL to be more consistent with devicons.