Add "types" import condition to fix esm type definition file not found#257
Open
isudzumi wants to merge 2 commits intobalazsbotond:masterfrom
Open
Add "types" import condition to fix esm type definition file not found#257isudzumi wants to merge 2 commits intobalazsbotond:masterfrom
isudzumi wants to merge 2 commits intobalazsbotond:masterfrom
Conversation
|
could you update this PR, tsup supports exporting .d.cts now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close #248
As of Typescript 4.7, when esmodule applications with
moduleResolution: nodenextuse this library, Typescript cannot find a declaration file for.mjsfile (https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#package-json-exports-imports-and-self-referencing).To fix the problem, add "types" field to import condition.
Details
About the problem
Here is example:
package.json{ "type": "module", "dependencies": { "urlcat": "^3.1.0" }, "devDependencies": { "typescript": "^5.0.4" } }tsconfig.json{ "compilerOptions": { "module": "nodenext", "moduleResolution": "nodenext", "strict": true } }This emits the following error
This PR fixes the issue.
About
postbuildTo find type definition file for
.mjs, it requires.d.mts.Ideally, tsup should add support for generating
.d.mtsor.d.ctsfile, but currently the feature is not implemented (egoist/tsup#760).So this PR copies
.d.tsto.d.mtsin apostbuildscript as a workaround.