Skip to content

Conversation

@sschuldenzucker
Copy link

Description

There is a new version of the Gyroscope 3CLP that allows scaling by rateproviders. This version adds the relevant factory events and pool events. This is framed as version 2 of the 3CLP, analogously to the ECLP.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

The new factory for this pool on Base is added to networks.yaml. No other such factories are deployed at the moment.

We have a pool created from this factory here: https://basescan.org/address/0x94deF775bf3Ef614A5325f50f0B8ba1a13198d52#readContract

We should test for this pool that:

  1. The pool is included correctly as a Gyro3Pool version 2
  2. The two rateproviders (for two of the three tokens, the third one being zero) are included correctly.
  3. The minting of LP shares (from seeding) is processed correctly

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas

dev -> master

  • I have checked that all beta deployments have synced
  • I have checked that the earliest block in the polygon pruned deployment is block, date/time
    • The earliest block is more than 24 hours old
  • I have checked that core metrics are the same in the beta and production deployments

Merges to dev

  • I have checked that the graft base is not a pruned deployment

…ctory on base

This is the same as the Gyro 3CLP but allows for rateproviders. Handled
as version 2 for the Gyro3Pool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant