Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize dns config #321

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Sanitize dns config #321

merged 2 commits into from
Mar 24, 2024

Conversation

bakito
Copy link
Owner

@bakito bakito commented Mar 24, 2024

set 'Use private reverse DNS resolvers' automatically to false on replica if 'Private reverse DNS servers' are empty, even if the flag is enabled on origin.
fixes #320

related with AdguardTeam/AdGuardHome#6820

@coveralls
Copy link

coveralls commented Mar 24, 2024

Pull Request Test Coverage Report for Build 8411063017

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 63.948%

Files with Coverage Reduction New Missed Lines %
pkg/config/env.go 4 79.65%
Totals Coverage Status
Change from base Build 8365773779: -0.04%
Covered Lines: 1231
Relevant Lines: 1925

💛 - Coveralls

@bakito bakito marked this pull request as ready for review March 24, 2024 17:46
@bakito bakito merged commit 1c4ea24 into main Mar 24, 2024
7 checks passed
@bakito bakito deleted the sanitize-dns-config branch April 4, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error syncing DNS server config
2 participants