Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Protobuf support to ListFieldFetcher and add tests #139

Closed
raminqaf opened this issue Nov 3, 2022 · 0 comments · Fixed by #158
Closed

Add Protobuf support to ListFieldFetcher and add tests #139

raminqaf opened this issue Nov 3, 2022 · 0 comments · Fixed by #158
Assignees
@raminqaf
Labels
area/unitTest Relates to unit tests component/gateway type/enhancement New feature or request

Comments

@raminqaf
Copy link
Contributor

raminqaf commented Nov 3, 2022

Currently, the ListFieldFetcher does not have any tests. We should add execution tests, conversion tests, and fetcher tests for it. Moreover, the ListFieldFetcher does not support Protobuf messages. This support should also be added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raminqaf raminqaf

Labels
area/unitTest Relates to unit tests component/gateway type/enhancement New feature or request
Projects
Quick
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Protobuf support to list field fetcher and add more tests bakdata/quick
2 participants
@raminqaf @DawidNiezgodka