Deprecate CUDA_ADD_LIBRARY #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDA_ADD_LIBRARYis deprecated after 3.10 (reference), and it limits the CUDA parallel compilation. Because many architectures are compiled serially,warp-ctcrequires almost 2 minutes to be compiled.In this PR,
add_library+ set project language with CUDA instead ofcuda_add_library. Then user can pass-t0through-DCMAKE_CUDA_FLAGSto enable CUDA parallel compilation. The compile time can be decreased from 2min to tens of second (~10x).CMAKE_CXX_STANDARDandCMAKE_CUDA_STANDARDto replace manually adding-std=c++11