Run lint

bahung1221 · Feb 14, 2021 · bd58ec9 · bd58ec9
1 parent f52a142
commit bd58ec9
Show file tree

Hide file tree

Showing 8 changed files with 35 additions and 20 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## v0.1.5 - 2021-02-13
+
+- Update linter rules.
+
+
 ## v0.1.4 - 2021-02-13
 
 ### Added

diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -1,2 +1,9 @@
+include: package:pedantic/analysis_options.yaml
+
 analyzer:
   exclude: [lib/raw/proto/**, example/**]
+
+linter:
+  rules:
+    omit_local_variable_types: false
+    unnecessary_this: false
diff --git a/example/lib/main.dart b/example/lib/main.dart
@@ -31,6 +31,7 @@ void decodeForEachGeoJsonType() async {
       print(geojson.properties);
       print(geojson.geometry.type);
       print(geojson.geometry.coordinates);
+      print('\n');
     }
 
     if (feature.geometryType == GeometryType.MultiPoint) {

diff --git a/lib/util/geojson.dart b/lib/util/geojson.dart
@@ -57,7 +57,7 @@ class GeoJsonMultiPolygon extends GeoJson<GeometryMultiPolygon> {
 }
 
 class GeoJsonFeatureCollection extends GeoJson {
-  final GeoJsonType type = GeoJsonType.FeatureCollection;
+  @override final GeoJsonType type = GeoJsonType.FeatureCollection;
   List<GeoJson> features;
 
   GeoJsonFeatureCollection({

diff --git a/lib/util/geometry.dart b/lib/util/geometry.dart
@@ -18,7 +18,7 @@ class Geometry {
 }
 
 class GeometryPoint extends Geometry {
-  final type = GeometryType.Point;
+  @override final type = GeometryType.Point;
   List<double> coordinates;
 
   GeometryPoint({
@@ -27,7 +27,7 @@ class GeometryPoint extends Geometry {
 }
 
 class GeometryMultiPoint extends Geometry {
-  final type = GeometryType.MultiPoint;
+  @override final type = GeometryType.MultiPoint;
   List<List<double>> coordinates;
 
   GeometryMultiPoint({
@@ -36,7 +36,7 @@ class GeometryMultiPoint extends Geometry {
 }
 
 class GeometryLineString extends Geometry {
-  final type = GeometryType.LineString;
+  @override final type = GeometryType.LineString;
   List<List<double>> coordinates;
 
   GeometryLineString({
@@ -45,7 +45,7 @@ class GeometryLineString extends Geometry {
 }
 
 class GeometryMultiLineString extends Geometry {
-  final type = GeometryType.MultiLineString;
+  @override final type = GeometryType.MultiLineString;
   List<List<List<double>>> coordinates;
 
   GeometryMultiLineString({
@@ -54,7 +54,7 @@ class GeometryMultiLineString extends Geometry {
 }
 
 class GeometryPolygon extends Geometry {
-  final type = GeometryType.Polygon;
+  @override final type = GeometryType.Polygon;
   List<List<List<double>>> coordinates;
 
   GeometryPolygon({
@@ -63,7 +63,7 @@ class GeometryPolygon extends Geometry {
 }
 
 class GeometryMultiPolygon extends Geometry {
-  final type = GeometryType.MultiPolygon;
+  @override final type = GeometryType.MultiPolygon;
   List<List<List<List<double>>>> coordinates;
 
   GeometryMultiPolygon({

diff --git a/lib/vector_tile.dart b/lib/vector_tile.dart
@@ -28,14 +28,14 @@ class VectorTile {
     return VectorTile(layers: layers);
   }
 
-  static VectorTile fromGeoJson({
-    @required List<GeoJson> features,
-    @required String layerName,
-    @required String extent,
-    @required String version,
-  }) {
-    // TODO
-  }
+  // static VectorTile fromGeoJson({
+  //   @required List<GeoJson> features,
+  //   @required String layerName,
+  //   @required String extent,
+  //   @required String version,
+  // }) {
+  //   // TODO
+  // }
 
   Future<void> toPath({@required String path}) async {
 

diff --git a/lib/vector_tile_feature.dart b/lib/vector_tile_feature.dart
@@ -36,9 +36,9 @@ class VectorTileFeature {
     this.values,
   });
 
-  static VectorTileFeature fromGeoJson(GeoJson geoJson) {
-    // TODO
-  }
+  // static VectorTileFeature fromGeoJson(GeoJson geoJson) {
+  //   // TODO
+  // }
 
   raw.VectorTile_Feature toRaw() {
     return raw.VectorTile_Feature(

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: vector_tile
-version: 0.1.4
+version: 0.1.5
 description: >-
   A simple Dart package to encode & decode Mapbox Vector Tile, A implementation of Mapbox Vector Tile specification.
 homepage: https://github.com/saigontek/dart-vector-tile
@@ -9,4 +9,6 @@ environment:
 dependencies:
   meta: ^1.2.4
   fixnum: ^0.10.11
-  protobuf: '>=1.1.0 <2.0.0'
+  protobuf: '>=1.1.0 <2.0.0'
+dev_dependencies:
+  pedantic: ^1.9.2