Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow arbitrary start and test commands #165

Closed
bahmutov opened this issue Apr 23, 2019 · 1 comment · Fixed by #166
Closed

allow arbitrary start and test commands #165

bahmutov opened this issue Apr 23, 2019 · 1 comment · Fixed by #166
Labels
released

Comments

@bahmutov
Copy link
Owner

Version 1.7.14 assumes that start and test commands are NPM script names. It would be nice to allow any commands. For example step 1 could be allowing passing arbitrary commands like this

start-test 'http-server -c-1 --silent' 8080 test

We could check the "start" argument - in this case "http-server -c-1 --silent" against NPM script names. Since it is NOT "start" or "test" or a script name, it would be its own command.
bahmutov added a commit that referenced this issue Apr 23, 2019
@bahmutov
feat: allow arbitrary commands, close #165
81e05aa
@bahmutov bahmutov mentioned this issue Apr 23, 2019
Merged
bahmutov added a commit that referenced this issue Apr 23, 2019
@bahmutov
feat: custom commands (#166)
2979b15 
Allows to pass in addition to NPM script names any commands. For example

```
start-test 'http-server -c-1 --silent' 8000 'npm run test -- --verbose'
```


* feat: allow arbitrary commands, close #165

* chore: add port argument to the test server script

* chore: add client script for testing

* chore: described custom commands in README
@bahmutov
Copy link
Owner Author

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: custom commands bahmutov/start-server-and-test
1 participant
@bahmutov