Avoid inadvertently invoking unwrapped request in vendor helper functions

[paulmelnikow]

• Tweak a couple names to improve readability

Tested locally by manually checking teamcity, and running my experimental recorded tests which cover travis.

[paulmelnikow]

Let me take a moment to explain these changes.

The cache function gets run millions of times a day, so clearly it works. 😄

It's 100+ lines, with no tests or doc, so it's difficult to read and reason about. The first thing I tried was finding where its argument was used, which was difficult because it was named f. Then I wondered, is this only used for json requests? No, it's behaving the same as request typically does. Would be clearer with the parameter name from their signature.

All the vendor badges invoke cache with a callback that takes a request parameter. This isn't require('request'), it's the caching request function which is created in cache. Devs might copy and paste code without realizing this, which is fine, though when code is factored into helper functions, as happens occasionally, they might not realize the request they are using has become request = require('request') assigned at the top of the file. That's what happened here with teamcity. Pulling it out of the module scope will prevent this error.

[espadrine]

That's a clearer name. We can probably make it clearer still. What do you think about vendorProcessing?

[paulmelnikow]

I'd be good with vendorProcessingFn.

[paulmelnikow]

Or vendorRequestHandler.

[espadrine]

Why do you want to require request every time we need it, instead of once and for all?

If you're worried about mistakenly calling it, we can change its name to httpRequest or something like that.

[paulmelnikow]

We only use it twice. It seems clearer to require it both times than introduce a new name. I don't feel that strongly though.