Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC add a menu to category pages #1842

Closed
wants to merge 1 commit into from
Closed

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Aug 3, 2018

Based on @tooomm 's #1808 (comment) on the new front-end design, I have put together a rough implementation based on that screenshot. This isn't intended as ready-to-merge, but it gives me a way to deploy something to staging so we can test something and move the conversation on.

A horizontal menu is probably not great for mobile users, so I've hidden it at low-res for now. In general I'd like to move towards a more mobile-friendly front-end although I'm aware that right now we are rendering most of our content in tables.

Something like this is probably OK as long as we have a relatively small number of categories (we've just increased to 11), but as discussed in #1762 (comment) I can see a case for moving to a situation where we might have a much larger number of menu items. I wonder if anyone has any ideas about how we could present this, particularly if we had many more 'categories' or 'headings' (more than you'd want on a single row).

Feedback generally welcome. Also probably worth keeping en eye on the issues as more users see the new layout.

@shields-ci
Copy link

Messages
📖

✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS

@chris48s
Copy link
Member Author

chris48s commented Aug 3, 2018

staging deploy at https://shields-staging-pr-1842.herokuapp.com

@tooomm
Copy link
Contributor

tooomm commented Aug 3, 2018

First observations:

  • The new "menu headline" is not centered over all page
  • When you switch between categories the old badges stay visible until they get replaced with the new ones. They should be hidden/removed with the category switch immediatly.
    This can be awkward because sometimes it takes a few seconds until they properly refresh and the correct ones are shown.

Both can be seen on this screenshot:
loading

@paulmelnikow paulmelnikow added the frontend The Docusaurus app serving the docs site label Aug 4, 2018
@paulmelnikow
Copy link
Member

Mind merging master into this branch when you have a moment? I wrote some steps here: #1866 (comment)

@platan
Copy link
Member

platan commented Aug 17, 2018

Good idea. Now I can easily move between categories. Before this I have to go back in browser to see all categories.
My note. After page is loaded we have a vertical list of categories. After choosing one category vertical list changes to horizontal. I would like to have it consistent - we can display horizontal list form the beginning.

@chris48s
Copy link
Member Author

Given @mbrandau wants to work on menu as part of some wider (much needed) redesign work in #1899 I'm going to put this on hold for the moment as I think it fits there more naturally. If #1899 stalls, I'll revisit this.

@tooomm
Copy link
Contributor

tooomm commented Nov 6, 2018

Is it worth revisiting and giving this the last finishing (as a interim solution at least)? @chris48s
Currently, it looks like the other approach hasn't been worked on since quite some time.

This would help a lot with category and site navigation in general!

@RedSparr0w
Copy link
Member

With more categories being added such as Activity #2448, It may be worth pushing ahead with this.

@paulmelnikow
Copy link
Member

@chris48s Would you like me to pick this up after #2441 is merged? Or would you like to tackle it?

@chris48s
Copy link
Member Author

chris48s commented Dec 7, 2018

I'm not particularly attached to it. I'm aiming to try and have a look at #2441 tomorrow. If you want to have a go at this once that's in, feel free. Cheers

paulmelnikow added a commit that referenced this pull request Jan 8, 2019
Adapted from @chris48s’ work from #1842.
@paulmelnikow
Copy link
Member

Reopened as #2682.

paulmelnikow added a commit that referenced this pull request Jan 9, 2019
Adapted from @chris48s’ work from #1842.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend The Docusaurus app serving the docs site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants