Turn on prettier (except repo root)

[paulmelnikow]

Follow-up to #1123.

This is going to conflict with open PRs. Before merging it, I want to get through a few open PRs which are making substantive changes in lib/:

• Refactor and test the SVG badge parser #1147
• Clean up request-handler, github-auth, and analytics; upgrade to Mocha 4 #1142
• When a global gh_token is configured, always use it #1118

The open PRs for service badges will conflict too, though the conflicts there will be smaller and so not as difficult to solve.

[paulmelnikow]

I proposed at #948 (comment) that we turn off semicolons for lib/ and service-tests/ before merging this.

[Daniel15]

Seems good to me. I don't really have any comments to add, since this is all automated.

[Daniel15]

Looks like a great use case for a format string.

[RedSparr0w]

Is there a prettier option for prefer template string?

[platan]

Do we want to add info about usage of prettier in this project in documentation, e.g. in CONTRIBUTING.md? And maybe one example command how to format code using prettier (or other tool). I'm using prettier for the first time and I found such commands prettier --write "{lib,service-tests}/**/*.js" and npm run lint -- --fix (which runs eslint --fix). We can configure pre-commit hooks as well.

[FezVrasta]

pre-commit hook would make much more sense than explaining commands to the contributors, the process should be transparent

[paulmelnikow]

Let's take one last pass through the recent open PRs that modify a lot of files in lib/, frontend/, services/`, and then rebase and merge this.

• Split front end into one page per category #1762 Split front end into one page per category #1808
• [RFC] Add Joi-based request validation to BaseJsonService and rewrite [NPM] and [node] badges; also affects [apm appveyor cdnjs clojars gem] #1743
• generate static examples without api call [apm appveyor cdnjs clojars gem npm uptimerobot] #1740
• send longer cache headers by default #1725
• loosely detect semver versions #1628

[paulmelnikow]

I'm not sure we'll be able to merge all of these in a timely way. How about we just go ahead and do this, and deal with the rebasing + conflicts? I worry if we wait until everything is clear we could be waiting a long time…

[RedSparr0w]

Yeah, that sounds fine to me 👍

[paulmelnikow]

@chris48s Does that work for you, too? Most of the outstanding rebasing work would likely fall on the three of us, so if we're cool with it, I'll revive this, update it, add some doc, and then merge it shortly after.

[chris48s]

Now seems like a good time to get this rebase and in. #1808 is in now. Happy to do the work to rebase #1740 as I'd like to update it once we hammer out #1743. Lets get this done before we start anything else big 👍

[shields-ci]

	Messages
📖	✨ Thanks for your contribution to Shields, @paulmelnikow!
📖	Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS

[paulmelnikow]

I spot-checked these and they look way cleaner, especially without the semis. The tester code looks especially pretty! ✨

[RedSparr0w]

Nice work, Changes are looking good.

[Daniel15]

Nice work! I miss the semicolons, but consistency is good. I'm happy either way, as long as it's consistent across everything :)

[paulmelnikow]

To make it easier to read the config changes, I reverted the formatting changes, which I'll merge separately. This PR will fail prettier-check in CI.

[shields-deployment]

This pull request was merged to master branch. Now this change is waiting for deployment.
Deploys usually happen every few weeks. After deployment changes are copied to gh-pages branch.

This badge displays deployment status:

[paulmelnikow]

I've posted guidance on resolving merge conflicts here: #1866 (comment)