Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension to "commits since" badge: allow counting from latest version tag #1955

Open
Lucretiel opened this issue Aug 23, 2018 · 4 comments
Open

Extension to "commits since" badge: allow counting from latest version tag #1955

Lucretiel opened this issue Aug 23, 2018 · 4 comments
Labels
service-badge Accepted and actionable changes, features, and bugs

Comments

@Lucretiel
Copy link

Many projects don't use Github Releases to track releases, but simply ordinary git tags. These show up in the GitHub releases page (for example: https://github.com/Lucretiel/joinery/releases), but aren't marked as releases in the API. It'd be nice if there was another endpoint– perhaps /commits-since/USER/REPO/latest-tag.svg– which counts commits after the most recent tag matching /\d+(\.\d+)/
@Lucretiel
Copy link
Author

Prior art: #993

@paulmelnikow
Copy link
Member

Hi, thanks for the suggestion! It's a nice idea.

To get the latest tag reliably currently requires many API calls (#875), so we may need a caching solution for that first.

@Lucretiel
Copy link
Author

Yeah, at the end of the day we'd need to implement GitHub paginating. We can fetch up to 100 tags per repo per call, and unfortunately I don't see any obvious way to only fetch new tags.

@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Aug 23, 2018
@agilgur5
Copy link
Contributor

agilgur5 commented May 24, 2019 •
edited
Loading

So /github/tag and /github/tag-pre (and /github/tag-date) currently get the latest SemVer tag (and date tag). Is it now possible that commits-since could extend that logic to allow for commits since latest SemVer?

Right now, I'm having the issue that a v0.1.11 release of mine is latest by date, but v1.0.1 is latest by SemVer. I can use tag to get it to show properly, but can't use commits-since anymore since it only supports latest release (no SemVer)

agilgur5 added a commit to agilgur5/react-signature-canvas that referenced this issue May 25, 2019
@agilgur5
(docs/hotfix): track latest release by SemVer
caf120a 
- "latest" in GitHub releases means latest by date, which means
  backports are considered latest by definition
  - currently 0.1.11 is showing as latest :/
    - using SemVer with the "tag" badge (not release anymore :/)
      more or less resolves this for the README, but GH releases page
      will always show by date :/

- "commits since" is also currently tracking "latest" release by date
  - no fix to this yet, c.f. badges/shields#1955 (comment)
agilgur5 added a commit to agilgur5/react-signature-canvas that referenced this issue May 25, 2019
@agilgur5
(docs/hotfix): track latest release by SemVer
8553adf 
- "latest" in GitHub releases means latest by date, which means
  backports are considered latest by definition
  - currently 0.1.11 is showing as latest :/
    - using SemVer with the "tag" badge (not release anymore :/)
      more or less resolves this for the README, but GH releases page
      will always show by date :/

- "commits since" is also currently tracking "latest" release by date
  - no fix to this yet, c.f. badges/shields#1955 (comment)
    - manually putting the latest SemVer tag for now :/ :/ :/ :/
agilgur5 added a commit to agilgur5/mst-persist that referenced this issue Jul 27, 2019
@agilgur5
(docs/fix): track latest release by SemVer
12ff92e 
- in case a backport release is added, such as a backport of the
  upcoming v0.1.1

- "latest" in GitHub releases means latest by date, which means
  backports are considered latest by definition
  - using SemVer with the "tag" badge (not release anymore :/)
    more or less resolves this for the README, but GH releases page
    will always show by date :/

- "commits since" is also currently tracking "latest" release by date
  - no fix to this yet, c.f. badges/shields#1955 (comment)
    - manually putting the latest SemVer tag for now :/ :/ :/ :/
@agilgur5 agilgur5 mentioned this issue Dec 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@paulmelnikow @Lucretiel @agilgur5 @chris48s