Skip to content

Fallback to GitHub handle for names with CJK characters #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fallback to GitHub handle for names with CJK characters #30

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3bf0a6
Initial plan
Copilot Oct 28, 2025
5b38db8
Add fallback to GitHub handle for names with unsupported characters
Copilot Oct 28, 2025
32af556
Improve has_unsupported_chars function based on code review
Copilot Oct 28, 2025
9139ded
Use more specific exception handling in has_unsupported_chars
Copilot Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions badge/apps/badge/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,17 @@ def fake_number():
return random.randint(10000, 99999)


def has_unsupported_chars(text):
"""Check if text contains characters outside the ASCII/Latin-1 range (>255)"""
if not text:
return False
try:
return any(ord(char) > 255 for char in text)
except (TypeError, AttributeError):
# Handle cases where text is not iterable or contains invalid characters
return True


def placeholder_if_none(text):
if text:
return text
Expand Down Expand Up @@ -306,6 +317,9 @@ def draw(self, connected):
screen.font = small_font
screen.brush = phosphor
name = placeholder_if_none(self.name)
# Use handle as fallback if name contains unsupported characters (e.g., Chinese)
if self.name and has_unsupported_chars(self.name):
name = self.handle if self.handle else name
w, _ = screen.measure_text(name)
screen.text(name, 80 - (w / 2), 16)

Expand Down