Stop cucumber Before hook clobbering mocha before.

[jcundill]

Differentiate between Before as a cucumber Hook and before as the cypress mocha hook. This PR allows both to be defined and invoked appropriately.

Also fix the issues with mocha before and after hooks getting called multiple times #214 (comment). Changed the loader to wrap the required imports into the describe block for the generated testsuite.

There is a sample repo to illustrate the results on hook invocation of this PR at https://github.com/jcundill/cypressHooks.git

Note: For global step definitions all mocha hooks are at the Global scope - so beforeEach applies to all scenarios, etc. As the support pages are included into the cypress runner outside of any test scopes.

For local step definitions, mocha hooks scope appropriately. Those in common are applied to all features individually - before and after is called at the feature level. Those in step definition and helper files scoped to a single feature are applied just to that feature. This seems OK to me.

Also there seems to be a bug in cypress itself with regard to the mocha after hook when specified at the global level. This hook is applied after the first test rather than after all of them - run the js files just_cypress and just_cypress2 included in the test repo to reproduce this outside of the cypress-cucumber-plugin

[lgandecki]

man, you've outran me here :) Thanks for the work! I've done the same change for adding the describe block inside the template, inspired by this comment : cypress-io/cypress#3323 (comment)

I was also going to remove overwriting of the before/after, but I was also thinking about not doing Before/After .. maybe calling them something like CucumberBefore CucumberAfter, so they are not confusing. It feels a bit weird to have both before and Before globally accessible that do something very different. What do you think? The other thing would be not to put them on window at all, but make people explicitly import them from our package.

[lgandecki]

🎉 This PR is included in version 1.14.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[vospascal]

updated to latest version..

Given('some description', () => {
cy.log("12321")
Cypress.log({message: '123213'})
console.log('sdfsdf')
}

or

When('some description', () => {
cy.log("12321")
Cypress.log({message: '123213'})
console.log('sdfsdf')
}

nothing gets logged anywhere... any idea's ?

[lgandecki]

Could you please create a separate issue?