Adding support for RDB version <= 12 and refactoring #19
Conversation
…y created tests pass
* Try fixing file system permissions for testcontainers in gha * Revert "Try fixing file system permissions for testcontainers in gha" This reverts commit 1dd2a36. * Debug file system permissions in gha * Change file permissions via container * MOAR debugging. I hate github actions. * Chown * ls -l inside container * Even more debugging and waiting for redis just in case * Sanity test privileged mode * Wait more * Rm privileged * Try syncing file before proceeding * try userns mapping * Try with command * With more complex cmd * debug * Try it all again * Reproduce * More context * See if it passes * fmt * Issue with toolchains * Stat * Fail * Try modifying user again * More debug * Extended debugging * Better output * Escape the curse of mounts
| @@ -0,0 +1 @@ | |||
| * @bimtauer | |||
There was a problem hiding this comment.
I added this in my fork as a precaution against hijacking since I did test-publish the python package rdb-py from there. I used a trusted publisher configured for my fork for this. Publishing the python bindings wont work from here. Let me know if you also want to publish 0.3 of the python lib from here first.
Sorry for not mentioning this ealier.
There was a problem hiding this comment.
All good! Once I publish the latest version on crates.io, I will hand it over to you and your repo becomes the main one. So we can keep it as that and you can do the rdb-py release afterwards.
| uses: PyO3/maturin-action@v1 | ||
| with: | ||
| command: upload | ||
| args: --non-interactive --skip-existing wheels-*/* |
There was a problem hiding this comment.
This will fail in this repository
| @@ -0,0 +1 @@ | |||
| * @bimtauer | |||
There was a problem hiding this comment.
All good! Once I publish the latest version on crates.io, I will hand it over to you and your repo becomes the main one. So we can keep it as that and you can do the rdb-py release afterwards.
Stumbled over this when wanting to create stats of an RDB dump. Python library redis-rbd-tools is outdated and doesn't support newer redis versions and this one was long archived but promising. So I went ahead and added support for new encoding types, refactored the code and added python bindings with Maturin.
Changelog:
Contributing this here as part of a bid to become maintainer of this project. Thanks again for the nice chat leading up to this!