Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback - Deprecated legacy backend #2048

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

awanlin
Copy link
Contributor

@awanlin awanlin commented Nov 20, 2024

Hey, I just made a Pull Request!

Deprecated legacy backend and fixed up a few TSDocs so the API Reports were correct.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@awanlin awanlin requested review from riginoommen, yashoswalyo and a team as code owners November 20, 2024 19:54
@awanlin awanlin requested a review from BethGriggs November 20, 2024 19:54
@backstage-goalie
Copy link
Contributor

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage-community/plugin-feedback-backend

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-feedback-backend workspaces/feedback/plugins/feedback-backend none v1.7.8

@04kash 04kash mentioned this pull request Nov 26, 2024
5 tasks
Copy link
Contributor

github-actions bot commented Dec 5, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Dec 5, 2024
@awanlin
Copy link
Contributor Author

awanlin commented Dec 6, 2024

Hi @yashoswalyo @riginoommen @BethGriggs, can you please review this PR? Would be really good to have this in place to help move the community forward and not use deprecated code and patterns.

@github-actions github-actions bot removed the stale label Dec 6, 2024
Copy link
Member

@yashoswalyo yashoswalyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yashoswalyo
Copy link
Member

We also don't need to export createRouter and RouterOptions in favour of new backend system

@awanlin awanlin merged commit 9265e67 into backstage:main Dec 6, 2024
11 checks passed
@awanlin awanlin deleted the feedback/deprecate-legacy-backend branch December 6, 2024 19:16
famibo pushed a commit to famibo/community-plugins that referenced this pull request Dec 9, 2024
… backend system. (backstage#2048)

Signed-off-by: Andre Wanlin <[email protected]>
Signed-off-by: Artur Bochert <[email protected]>
CryptoRodeo pushed a commit to CryptoRodeo/community-plugins that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants