Introducing the Linguist plugin by ahhhndre · Pull Request #14718 · backstage/backstage

ahhhndre · 2022-11-20T19:16:31Z

Hey, I just made a Pull Request!

Introducing the Linguist plugin: get a nice breakdown of all the languages that make up an Entity in the Catalog! This is great for those SCMs that don't offer this feature like Azure DevOps or BitBucket, but it still works with the others as well. Closes #9733

✔️ Checklist

A changeset describing the change and affected packages. (more info)
Added or updated documentation
Tests for new functionality and regression tests for bug fixes
Screenshots attached (for UI changes)
All your commits have a Signed-off-by line in the message. (more info)

github-actions · 2022-11-20T19:16:55Z

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

@backstage/catalog-model

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
example-app	packages/app	none	`v0.2.78-next.3`
example-backend	packages/backend	none	`v0.2.78-next.3`
@backstage/catalog-model	packages/catalog-model	none	`v1.1.4-next.1`
@backstage/plugin-linguist-backend	plugins/linguist-backend	minor	`v0.0.0`
@backstage/plugin-linguist-common	plugins/linguist-common	minor	`v0.0.0`
@backstage/plugin-linguist	plugins/linguist	minor	`v0.0.0`

ahhhndre · 2022-11-20T19:17:53Z

Last Christmas I created a plugin
but it took me a year to open source it

@freben 😉

packages/backend/src/plugins/linguist.ts

plugins/linguist/src/components/LinguistCard/LinguistCard.tsx

plugins/linguist/README.md

ahhhndre

Somethings of note for when you start to review this

backstage-goalie · 2022-11-20T19:43:56Z

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

ahhhndre · 2022-11-22T21:19:14Z

@freben, could use some help. Somehow when I rebased I got 3 commits missed into my branch and I'm not sure how best to get them out. Any suggestions? My git-fu is failing me

GLundh · 2022-11-23T22:18:14Z

This is such a great plugin. Thanks for contributing this. Looking forward to have it merged :)

freben

Hi, i know this is a draft, but here are some random comments!

plugins/linguist-backend/package.json

plugins/linguist/package.json

.changeset/serious-horses-juggle.md

plugins/linguist-backend/README.md

plugins/linguist-backend/src/service/router.ts

plugins/linguist/README.md

plugins/linguist/src/api/LinguistApi.ts

plugins/linguist/src/components/LinguistCard/LinguistCard.tsx

github-actions · 2022-12-01T14:05:21Z

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

ahhhndre · 2023-01-12T21:08:15Z

Alright, I'm still working through the comments so you can hold off on this for a while still. Making progress though 👍

github-actions · 2023-02-01T10:39:07Z

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

freben · 2023-02-03T10:16:21Z

@ahhhndre just checking in, is it at the point where just a rebase and merge and then tweak, would be desirable?

Signed-off-by: Andre Wanlin <andrewanlin@gmail.com> Removed refresh and permissions Signed-off-by: Andre Wanlin <andrewanlin@gmail.com> Small database refactor and improved naming Signed-off-by: Andre Wanlin <andrewanlin@gmail.com> Refactor stringifyEntityRef usage Signed-off-by: Andre Wanlin <andrewanlin@gmail.com> Fixed up yarn.lock Signed-off-by: Andre Wanlin <andrewanlin@gmail.com>

Signed-off-by: Andre Wanlin <andrewanlin@gmail.com>

ahhhndre · 2023-02-12T18:28:49Z

Alright, at this stage I think it's good for approval and getting merged in, but if you want to do another review that works for me as well @freben

freben

Let's go!

github-actions · 2023-02-14T10:49:10Z

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.11.0 release, scheduled for Tue, 14 Feb 2023.

github-actions bot added the area:catalog Related to the Catalog Project Area label Nov 20, 2022

backstage-goalie bot assigned freben and tudi2d Nov 20, 2022

ahhhndre commented Nov 20, 2022

View reviewed changes

packages/backend/src/plugins/linguist.ts Show resolved Hide resolved

ahhhndre commented Nov 20, 2022

View reviewed changes

plugins/linguist/src/components/LinguistCard/LinguistCard.tsx Outdated Show resolved Hide resolved

ahhhndre commented Nov 20, 2022

View reviewed changes

plugins/linguist/README.md Outdated Show resolved Hide resolved

ahhhndre commented Nov 20, 2022

View reviewed changes

github-actions bot added area:documentation Improvements or additions to documentation area:microsite Changes to backstage.io area:scaffolder Everything and all things related to the scaffolder project area search area:techdocs Related to the TechDocs Project Area labels Nov 20, 2022

ahhhndre force-pushed the topic/introduce-linguist-plugin branch from 1572dc7 to 7354b23 Compare November 20, 2022 19:39

github-actions bot removed area:scaffolder Everything and all things related to the scaffolder project area area:documentation Improvements or additions to documentation area:microsite Changes to backstage.io search area:techdocs Related to the TechDocs Project Area labels Nov 20, 2022

ahhhndre force-pushed the topic/introduce-linguist-plugin branch from 7354b23 to eea33cc Compare November 21, 2022 23:26

ahhhndre force-pushed the topic/introduce-linguist-plugin branch from eea33cc to ddc272f Compare November 22, 2022 21:21

freben force-pushed the topic/introduce-linguist-plugin branch from ddc272f to a1ca9da Compare November 24, 2022 13:02

freben reviewed Nov 24, 2022

View reviewed changes

github-actions bot added the stale label Dec 1, 2022

ahhhndre force-pushed the topic/introduce-linguist-plugin branch from a1ca9da to 97154c7 Compare December 4, 2022 00:59

ahhhndre requested review from a team and backstage-service as code owners January 7, 2023 22:28

ahhhndre force-pushed the topic/introduce-linguist-plugin branch from 68fe14e to 71ff35d Compare January 12, 2023 19:40

ahhhndre force-pushed the topic/introduce-linguist-plugin branch 2 times, most recently from b8e502a to 2e9d21d Compare January 22, 2023 19:11

github-actions bot added the stale label Feb 1, 2023

freben removed the stale label Feb 3, 2023

ahhhndre force-pushed the topic/introduce-linguist-plugin branch from 2e9d21d to 24fa0c8 Compare February 4, 2023 19:29

ahhhndre requested a review from a team as a code owner February 4, 2023 19:29

ahhhndre requested a review from benjdlambert February 4, 2023 19:29

ahhhndre force-pushed the topic/introduce-linguist-plugin branch from 0274090 to 0bafb08 Compare February 4, 2023 19:30

ahhhndre added 5 commits February 11, 2023 14:59

Refactor age to use HumanDuration

bb1cfed

Signed-off-by: Andre Wanlin <andrewanlin@gmail.com>

Refactored createRouter args

d327896

Signed-off-by: Andre Wanlin <andrewanlin@gmail.com>

Refactored processing

54f08f8

Signed-off-by: Andre Wanlin <andrewanlin@gmail.com>

Organized backend API

672eade

Signed-off-by: Andre Wanlin <andrewanlin@gmail.com>

ahhhndre force-pushed the topic/introduce-linguist-plugin branch from a26837b to 672eade Compare February 11, 2023 21:00

ahhhndre added 2 commits February 11, 2023 15:02

Fixed ordering

027d58f

Signed-off-by: Andre Wanlin <andrewanlin@gmail.com>

Updated API Report

a021b24

Signed-off-by: Andre Wanlin <andrewanlin@gmail.com>

freben approved these changes Feb 14, 2023

View reviewed changes

freben merged commit bba9cab into backstage:master Feb 14, 2023

benjdlambert mentioned this pull request Feb 14, 2023

Version Packages #16240

Merged

ahhhndre mentioned this pull request Feb 15, 2023

Corrected Linguist README #16362

Merged

5 tasks

This was referenced Feb 27, 2026

🌱 CNCF mission generation 2026-02-27 kubestellar/console-kb#6

Closed

🌱 CNCF mission generation 2026-02-27 kubestellar/console-kb#11

Merged

Conversation

ahhhndre commented Nov 20, 2022

Hey, I just made a Pull Request!

✔️ Checklist

Uh oh!

github-actions bot commented Nov 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Missing Changesets

Changed Packages

Uh oh!

ahhhndre commented Nov 20, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahhhndre left a comment

Choose a reason for hiding this comment

Uh oh!

backstage-goalie bot commented Nov 20, 2022

Uh oh!

ahhhndre commented Nov 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GLundh commented Nov 23, 2022

Uh oh!

freben left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 1, 2022

Uh oh!

ahhhndre commented Jan 12, 2023

Uh oh!

github-actions bot commented Feb 1, 2023

Uh oh!

freben commented Feb 3, 2023

Uh oh!

ahhhndre commented Feb 12, 2023

Uh oh!

freben left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Nov 20, 2022 •

edited

Loading

ahhhndre commented Nov 22, 2022 •

edited

Loading