[TechDocs] Fix docker pull default on cli generate command#12051
Merged
[TechDocs] Fix docker pull default on cli generate command#12051
Conversation
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
github-actions
bot
added
awaiting-review
area:techdocs
Contributor
Changed Packages
|
Rugvip
approved these changes
Jun 15, 2022
emmaindal
approved these changes
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
Looks like a regression may have been introduced in the major version upgrade of
commanderin #10617, which causedtechdocs-cli generateto never pull the latest image, rather than respecting the--no-pullflag (relevant upstream change here tj/commander.js#1652).Closes #11553
✔️ Checklist
Signed-off-byline in the message. (more info)