Skip to content

fix(annotate): strip document-authored CSP meta tags that block the annotation bridge #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
backnotprop merged 1 commit into from
Aug 10, 2026
+43 −3
Merged

fix(annotate): strip document-authored CSP meta tags that block the annotation bridge #1259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/ui/components/html-viewer/srcdoc.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3562,4 +3562,29 @@ describe("injectIntoHead", () => {
);
expect(injectIntoHead("<p>no head</p>", "[X]")).toBe("[X]<p>no head</p>");
});

test("removes document-authored CSP meta tags so the bridge can execute", () => {
// The exact tag Plannotator's own portable guided-review exports embed;
// with it present the inline bridge script is blocked and annotation dies.
const csp =
'<meta http-equiv="Content-Security-Policy" content="default-src \'none\'; style-src \'unsafe-inline\'; img-src data:; font-src \'none\'; connect-src \'none\'; media-src \'none\'; object-src \'none\'; base-uri \'none\'; form-action \'none\'; frame-src \'none\'">';
const out = injectIntoHead(`<html><head>${csp}<title>t</title></head><body/></html>`, "[X]");
expect(out).not.toMatch(/content-security-policy/i);
expect(out).toContain("[X]</head>");
expect(out).toContain("<title>t</title>");

// Attribute-order, quoting, casing, and self-closing variants.
const variants = [
"<meta content=\"default-src 'none'\" http-equiv=content-security-policy>",
"<META HTTP-EQUIV='Content-Security-Policy' CONTENT=\"script-src 'none'\" />",
"<meta http-equiv = \" content-security-policy \" content=\"default-src 'self'\">",
];
for (const tag of variants) {
expect(injectIntoHead(`<head>${tag}</head>`, "[X]")).not.toMatch(/http-equiv/i);
}

// Other meta tags survive untouched.
const keep = '<meta http-equiv="refresh" content="0"><meta charset="utf-8">';
expect(injectIntoHead(`<head>${keep}</head>`, "[X]")).toContain(keep);
});
});
21 changes: 18 additions & 3 deletions packages/ui/components/html-viewer/srcdoc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,26 @@ export function buildSrcdocInjection({
return `<style>${themeCSS}${ANNOTATION_HIGHLIGHT_CSS}${diffCSS}</style><script>${BRIDGE_SCRIPT}</script>`;
}

/**
* A document-authored CSP `<meta>` tag (e.g. `default-src 'none'` in
* Plannotator's own portable guided-review exports) blocks the inline bridge
* script and disables annotation entirely. The iframe `sandbox` attribute is
* the security boundary for the annotate surface; the page's CSP was written
* for its standalone context, so it is removed before injection.
*/
const META_CSP_RE =
/<meta\s[^>]*http-equiv\s*=\s*["']?\s*content-security-policy\s*["']?[^>]*\/?>/gi;

export function neutralizeMetaCsp(rawHtml: string): string {
return rawHtml.replace(META_CSP_RE, "<!-- plannotator: meta CSP removed for annotation -->");
}

/** Splice the injection just before `</head>`, or prepend when there is none. */
export function injectIntoHead(rawHtml: string, injection: string): string {
const headClose = rawHtml.indexOf("</head>");
const html = neutralizeMetaCsp(rawHtml);
const headClose = html.indexOf("</head>");
if (headClose !== -1) {
return rawHtml.slice(0, headClose) + injection + rawHtml.slice(headClose);
return html.slice(0, headClose) + injection + html.slice(headClose);
}
return injection + rawHtml;
return injection + html;
}