Skip to content

test(review): repair guide virtualization mock and run its tests in CI #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
backnotprop merged 1 commit into from
Aug 5, 2026
Merged

test(review): repair guide virtualization mock and run its tests in CI #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ jobs:
packages/review-editor/components/FileHeader.edit.test.tsx
packages/review-editor/edit/useEditSession.recovery.test.tsx
packages/review-editor/edit/selectionActionPopover.test.ts
packages/review-editor/components/AllFilesCodeView.lifecycle.test.tsx
packages/review-editor/components/guide/GuideSectionCard.test.tsx
packages/review-editor/components/guide/GuideView.test.tsx
packages/review-editor/hooks/useReviewSearch.test.tsx
packages/ui/components/AnnotationPanel.props.test.tsx
packages/ui/components/Viewer.consumer.test.tsx
Expand Down
4 changes: 4 additions & 0 deletions packages/review-editor/components/AllFilesCodeView.lifecycle.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ mock.module('@pierre/diffs/react', () => ({
}));
return <div ref={props.containerRef} className={props.className} />;
}),
// AllFilesCodeView imports EditProvider alongside CodeView/useStableCallback.
// mock.module replaces the whole specifier, so every value export the
// component reads must be present here or the import throws at load time.
EditProvider: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
useStableCallback: <T extends (...args: never[]) => unknown>(callback: T): T => {
const callbackRef = useRef(callback);
callbackRef.current = callback;
Expand Down
Loading