-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Basis: Fix styling of responsive dropdown on smaller screens on RTL #4070
Comments
I just wanted to quickly raise this; need to also test multi-level menus. |
I'd also like to revisit the indentation of child menu items, as that won't work on menus with lots of depth. Maybe removing that can be part of the RTL fixes? |
@jenlampton Do you suggest to apply the results of a indentation revisit also to LTR? If so, I'd prefer a separate issue. |
If the fix for both RTL and too-many levels of indentation is removing some or indentation, then we only need one PR. But we do have another issue where we can talk about that: #2370 |
Only, #2370 isn't about the Basis theme (unlike this RTL issue). The issue which introduced the indentation (only for Basis) is #2553. Do you suggest to revoke the indentation also for Basis? If so, I'd like to argue against it, but where? Here some options:
|
This is a follow-up to #2553
The text was updated successfully, but these errors were encountered: