Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Basis: Fix styling of responsive dropdown on smaller screens on RTL #4070

Open
klonos opened this issue Sep 18, 2019 · 5 comments
Open

Comments

@klonos
Copy link
Member

klonos commented Sep 18, 2019

This is a follow-up to #2553

LTR
RTL

@klonos
Copy link
Member Author

klonos commented Sep 18, 2019

I just wanted to quickly raise this; need to also test multi-level menus.

@jenlampton
Copy link
Member

jenlampton commented Sep 23, 2019

I'd also like to revisit the indentation of child menu items, as that won't work on menus with lots of depth. Maybe removing that can be part of the RTL fixes?

@olafgrabienski
Copy link

I'd also like to revisit the indentation of child menu items (...)

@jenlampton Do you suggest to apply the results of a indentation revisit also to LTR? If so, I'd prefer a separate issue.

@jenlampton
Copy link
Member

jenlampton commented Sep 23, 2019

If the fix for both RTL and too-many levels of indentation is removing some or indentation, then we only need one PR. But we do have another issue where we can talk about that: #2370

@olafgrabienski
Copy link

But we do have another issue where we can talk about that: #2370

Only, #2370 isn't about the Basis theme (unlike this RTL issue). The issue which introduced the indentation (only for Basis) is #2553. Do you suggest to revoke the indentation also for Basis? If so, I'd like to argue against it, but where? Here some options:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants