Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Make sure Basis looks and works decently when used as an admin theme. #2653

Open
1 task done
klonos opened this issue Apr 25, 2017 · 7 comments
Open
1 task done

Comments

@klonos
Copy link
Member

klonos commented Apr 25, 2017

Related issues:


This came up in #1725 (comment)

Minor styling issue (tested in Chrome on Mac): The position of the X-Button doesn't align well, see screenshot:

The CSS thing is a Basis theme problem. Recommend open a new issue please.

I'm opening this issue here because I could not reproduce the styling problem on a vanilla 1.x installation. At the time of writing this, we do not have a way to invoke a pop-up dialog in the front-end, so what I've done is switch the admin theme to Basis, and navigated to the manage blocks UI in order to see what a dialog looks like. Here's how that page is being rendered:

image

...ignoring this mess for a moment in order to verify the issue with the dialog styling, I just hit one of the "Add block" buttons and here's what the dialog looks like:

image

...same with the "Configure block" dialogs; no styling issues:

image

With #1725 we'll be introducing something new: dialogs, which are a component usually (up until now) used in the backend only, are now to be used in the front-end too. So, the point is that we should make sure that Basis (and any theme that ships with core really) looks and works decently when used as an admin theme.

@olafgrabienski
Copy link

Basis is meant as a frontend theme, and I guess improving it to be used as an admin theme would be a huge task. Shouldn't we limit the task to former 'backend only' components like the modal dialog?

@klonos
Copy link
Member Author

klonos commented Apr 26, 2017

Sure, but it doesn't have to be perfect; just decent and usable. As you can see from the screenshot above, the manage blocks UI is terribly broken.

@olafgrabienski
Copy link

it doesn't have to be perfect; just decent and usable

Yes, that would be nice, absolutely. Let's however avoid the impression that Basis is an admin theme alternative.

@klonos
Copy link
Member Author

klonos commented Apr 26, 2017

Let's however avoid the impression that Basis is an admin theme alternative.

@olafgrabienski there's quite a lot of people that switch their sites to using the same theme as front/back-end. The reason is that when authors are editing nodes, they can be confused to see another theme. Some even get the impression that the site is broken. I've had some use cases with small sites (where the owner is the sole author of content and they happen to not be technically-savvy) where they kept asking "Why aren't the changes we've discussed applied everywhere? You only seem to have fixed the front page."

Some feel the opposite way and say that it is a good thing to be switching to another theme when in edit mode. So the fact is that so long as there is an option that allows people to switch to Basis as an admin theme, some people will do just that. Telling them "Yeah, but it is not intended to be used as an admin theme" would make them say "Then please remove it from being an option in the admin theme drop-down". That's why in the issue summary I said:

...the point is that we should make sure that Basis (and any theme that ships with core really) looks and works decently when used as an admin theme.

And I'm sure the other way around applies where some might be using backend-intended themes like Seven as front-end themes.

Besides, I strongly remember that when @wesruv was developing Basis kept asking opinions on things that dealt with the backend, like the drag handler on draggable table rows (he wanted to replace the cross with something that resembled the 3 horizontal lines we use in the hamburger mobile menu). He in fact seems to have actually themed tables in Basis 👍 :

image

@docwilmot
Copy link
Contributor

Absolutely agree with @klonos here. If Basis is that much broken as an admin theme it definitely has to be fixed. Marking as bug.

@olafgrabienski
Copy link

I agree too, @klonos . Changed my mind, even if I wouldn't recommend to use Basis as an admin theme. (Guess I'm one of the "it is a good thing to be switching to another theme when in edit mode" guys, but I see there other approaches.)

@stpaultim
Copy link
Member

If this one is addressed, let's be sure to look at the specific issue raised here:
#2259

Problems with Manage Blocks page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants