Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basis: issues when used as the admin theme. #2259

Closed
klonos opened this issue Sep 30, 2016 · 6 comments
Closed

Basis: issues when used as the admin theme. #2259

klonos opened this issue Sep 30, 2016 · 6 comments

Comments

@klonos
Copy link
Member

klonos commented Sep 30, 2016

I don't know if we want to support using it as the admin theme, but we are not currently preventing users from doing so. Here's how things look in the "Manage blocks" page:

backdrop-basis-used_as_admin_theme-manage_blocks_page

@klonos
Copy link
Member Author

klonos commented Sep 30, 2016

...perhaps we could be adding a class like admin in the body tag when we are in the admin backend. This way, themes that want to support being used in the admin UI can target things easily or even use a separate admin.css file that holds all their .admin * rules.

@wesruv
Copy link
Member

wesruv commented Oct 4, 2016

@klonos great catch!

This one just needs some special love, shouldn't be hard to fix this one.

@klonos
Copy link
Member Author

klonos commented Oct 4, 2016

Thanx @wesruv. Not a priority I guess since as I already mentioned I don't think there will be more than a handful of people using Basis as their admin theme.

@stpaultim
Copy link
Member

Closing as duplicate. #2653

@klonos
Copy link
Member Author

klonos commented Aug 9, 2020

Yeah 😞 ...shame on me.

@klonos klonos closed this as completed Aug 9, 2020
@stpaultim
Copy link
Member

Shame I me. It was my intention to close it myself. I must have forgotten.

:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants