Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE v7 around the corner - things to keep in mind #88

Closed
indigoxela opened this issue Mar 3, 2024 · 7 comments · Fixed by #91
Closed

TinyMCE v7 around the corner - things to keep in mind #88

indigoxela opened this issue Mar 3, 2024 · 7 comments · Fixed by #91

Comments

@indigoxela
Copy link
Member

indigoxela commented Mar 3, 2024

Huge surprise: license change! OK for us, GPLv2 with GPLv2+ ... Saw it by accident, here a mini discussion: tinymce/tinymce#9453
And also: https://github.com/tinymce/tinymce/blob/main/LICENSE.md Probably more discussion to come out there.

After switching to 7, I'll have to update related license mentions...

It was clear (as it was documented and console-nagged), that the template plugin will be removed in 7.x. - it has been hidden in this module (wasn't available via builder), but some adventurous admins might have used it via custom profiles. Add a note to the readme / release notes.

Eventually I'll wait until the first release after 7.0.0, anyway - have to check the amount of changes.

@indigoxela
Copy link
Member Author

Updated finding: seems like there'll be a "license key check" in init function, which means, we'd have to update the default options in our module (no big deal).

https://github.com/tinymce/tinymce/blob/main/modules/tinymce/src/core/main/ts/init/LicenseKeyValidation.ts

No statement or documentation re that, yet. 🤷 We'll see.

Keep an eye on the changelog

@indigoxela
Copy link
Member Author

indigoxela commented Mar 22, 2024

Version 7.0 is out, version 6.8 will be supported until 2025-06-06.

The documentation for the license key option's here.

@indigoxela
Copy link
Member Author

In fact, 7.x also seems to be a security hardening version, which completes fixing an XSS issue, which was worked around in 6.8.1.

@indigoxela
Copy link
Member Author

indigoxela commented Mar 28, 2024

Reopening just to keep things in mind for the release notes... No need to rush, though. Iframes in editor content are uncommon in Backdrop, unnecessary, and won't even display after saving when the "Limit allowed HTML tags" filter is on.

Sure, admins still can accomplish insecure setups (with some effort), but then ... 🤷

@indigoxela indigoxela reopened this Mar 28, 2024
@indigoxela
Copy link
Member Author

It might make sense to mention the changed trigger key for markdown conversion (space). And the addions of chars. Or maybe override to previous defaults?

@indigoxela
Copy link
Member Author

indigoxela commented Mar 30, 2024

Another change in 7: highlight_on_focus is now true by default... not sure, yet. It seems an A11Y improvement.

@indigoxela
Copy link
Member Author

Release is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant