Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run some checks via GHA #81

Closed
indigoxela opened this issue Feb 10, 2024 · 2 comments · Fixed by #86
Closed

Run some checks via GHA #81

indigoxela opened this issue Feb 10, 2024 · 2 comments · Fixed by #86

Comments

@indigoxela
Copy link
Member

This module has no automated tests, but phpcs and possibly jshint are good candidates to run on PRs.

@indigoxela
Copy link
Member Author

Nice! It works.

But 72 errors with jshint. Hm, better fix them in a follow-up.

@indigoxela
Copy link
Member Author

indigoxela commented Feb 10, 2024

Just realized, there's an unused var in code-checks.yml, or more precisely, an obsolete step.

And when I'm at it - workflow and job with the same name look odd.

... And when I'm at it - check if newer phpcs version (new maintainership!!) are available via shivammathur/setup-php@v2 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant