-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anchor button option to profile builder #74
Comments
@indigoxela got a PR, seems to be easier than I thought. |
Oh, not done. The button is there but not the plugin. |
Fixed. |
Yes, there are some plugins not added to the builder - for different reasons. When I first looked at the anchor plugin, I didn't find that it provides anything that's not already possible via the backdroplink plugin. |
Still not a huge fan of that plugin, but I understand, that people may want it. Here's an alternate PR, which also prevents a "responsibility conflict" with the backdroplink plugin. Want to test? |
I've a client where they are using the CKEditor version of the anchor button right now, and may need it here if we switch them. I figure it's easier to add here than create a separate module. |
@indigoxela I've tested your PR and it fully works. No conflict. Out of curiosity I tried to set an anchor with the backdroplink plugin by filling in the Unique Identifier and leaving the href blank. But it disappears. Not sure if that's TinyMCE cleaning up or if I'm doing it wrong. But regardless it's less confusing to have a dedicated button and an icon on the actual anchor. If I find it confusing, then probably so do my clients. |
Ah, right, that was the point... The trouble adding an empty link (no href value) is partly caused by the core link dialog, partly the backdroplink plugin. 😉 A good reason to add the anchor plugin to the builder. |
Is it possible to add anchor button as an option with the profile builder?
Looks like it's possible to add an anchor button manually in the profile JSON:
The text was updated successfully, but these errors were encountered: