Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow themes to provide css files for content_css out of the box #63

Closed
indigoxela opened this issue Dec 14, 2023 · 1 comment · Fixed by #64
Closed

Allow themes to provide css files for content_css out of the box #63

indigoxela opened this issue Dec 14, 2023 · 1 comment · Fixed by #64

Comments

@indigoxela
Copy link
Member

indigoxela commented Dec 14, 2023 •
edited
Loading

Struggled a bit with CKE5 (again) today, and realized, that this module does allow setting CSS files for content via admin UI, but it would also be cool, if themes could set that automatically.

Theme developers know best, which files matter for content display.
indigoxela added a commit that referenced this issue Dec 14, 2023
@indigoxela
Issue #63: Allow themes to provide css files for content_css
ff93a77
@indigoxela indigoxela mentioned this issue Dec 14, 2023
Merged
@indigoxela
Copy link
Member Author

indigoxela commented Dec 14, 2023 •
edited
Loading

Hm... have to test the "base theme" part, this code looks fishy.
Base theme CSS shouldn't be after sub theme CSS, and subtheme CSS should override base... 🤔

Edit: switched order, but still have to test...

indigoxela added a commit that referenced this issue Dec 15, 2023
@indigoxela
Issue #63: Allow themes to provide css files for content_css (#64)
012d401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #63: Allow themes to provide css files for content_css backdrop-contrib/tinymce
1 participant
@indigoxela