Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists and feature parity with CK5 #60

Closed
indigoxela opened this issue Dec 13, 2023 · 5 comments · Fixed by #61
Closed

Lists and feature parity with CK5 #60

indigoxela opened this issue Dec 13, 2023 · 5 comments · Fixed by #61

Comments

@indigoxela
Copy link
Member

CKE5 provides additional list properties for OL elements.

While TinyMCE provides list styles (and a little hidden the "start" attribute), it doesn't provide the "reversed" property out of the box.
To achive that, a custom plugin is needed.

As a context menu it would be quite easy. The UX might not be ideal because of different dialogs for the same element...

@indigoxela
Copy link
Member Author

indigoxela commented Dec 13, 2023

Looks OK, works... not sure, yet.
listprops-context-menu

The usual glitch - are people aware of the context menu and how to add it to profiles?

Another option would be a context toolbar (like in tinymce_imce), but they're a bit ... visually noisy.

@yorkshire-pudding
Copy link

I wasn't aware of context menus or how to add to profiles.
I would prefer context menu to context toolbar
The only way I could figure out doing start (just learned that is an HTML feature) was editing source code; am I missing an easier trick?

@indigoxela
Copy link
Member Author

Yay, feedback! 🎉

I wasn't aware of context menus or how to add to profiles.

Profiles can set them like that: https://github.com/backdrop-contrib/tinymce/blob/1.x-1.x/config/tinymce.profiles.default.json#L10

Note that the new backdroplistprops context menu isn't added there, yet.

Figuring out, which one's are available in an active editor ... can be done via console. On a page (node form) with an active editor run following in your browser dev tools:

tinymce.activeEditor.ui.registry.getAll('contextMenus').contextMenus 

That's maybe not very obvious. 🙊 And a bit nerdish... Any plugin can ship with additional contextmenus.

I would prefer context menu to context toolbar

May I know the reason?

@indigoxela
Copy link
Member Author

While the initial PR is fine as a proof-of-concept, it has bad UX in many ways.

  1. Two different dialogs, both just containing a single form item, one button named "List properties", which promises more than it provides
  2. When the focus isn't inside the OL, the context menu works as expected, but the "List props" button appears disabled (quirk in the "lists" plugin)
  3. OL has a context menu, UL has not (start/reversed only work on OL) - confusing
  4. The context menu's there without the advlist plugin, but its functionality (start/reversed) is quite exotic - confusing

So I'll have to think the UX over a bit. And I don't think, this is an urgent feature, anyway.

... And a little more feedback maybe ...

@indigoxela
Copy link
Member Author

Already better: a single button, a single dialog. And as I dropped using listprop button from lists plugin, the "disabled" quirk is also gone.

new-listprop-dialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants