Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox and floated images and dragging in content or replacing via toolbar button #56

Closed
indigoxela opened this issue Nov 20, 2023 · 1 comment · Fixed by #57
Closed

Comments

@indigoxela
Copy link
Member

indigoxela commented Nov 20, 2023

There are some annoying bugs with images - only with Firefox.

Here for reference an upstream issue: tinymce/tinymce#9129

Problem 1

When images are displayed as block element, either by "display" directly, or implicit by float, the images aren't draggable inside the editor content.

Problem 2

When trying to replace an image, and that image is floated or display-block, the new image gets added instead that it replaces the existing one.

Currently to me these two problems seem related somehow.

The weird part: it only occurs, if using the toolbar buttons (both, backdropimage or tinymce_imce plugin are affected).
It I use the doubleclick, which the backdropimage plugin provides, no duplication happens.

Tried to find something related in the Mozilla issue queue, but didn't find anything obvious.
Tried Tiny v 5 in above upstream issue demo - that didn't show that bug.

@indigoxela
Copy link
Member Author

indigoxela commented Nov 21, 2023

Another related upstream issue: tinymce/tinymce#8522

I can confirm that it has something to do with selection. So editor.selection.select(node) seems a valid workaround for duplicated images on insert (from image browser).

And the dragging problem also has to do with selection, it seems.

Another problem caused by the same glitch - removing selected images via key does not work, when image is floated.
And also cut/paste inside the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant