Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some notification messages with markup never displayed #54

Closed
indigoxela opened this issue Nov 20, 2023 · 1 comment · Fixed by #55
Closed

Some notification messages with markup never displayed #54

indigoxela opened this issue Nov 20, 2023 · 1 comment · Fixed by #55

Comments

@indigoxela
Copy link
Member

indigoxela commented Nov 20, 2023 •
edited
Loading

They don't work, get "swallowed" by the notificationManager, if they contain markup that's not allowed inside paragraph. Additionally there's console nagging.

Some image validation messages contain div, ul, li... As markup doesn't make much sense in these messages, maybe better strip all tags. (Per default these messages are supposed to get displayed in the B message container, where markup makes more sense.)
indigoxela added a commit that referenced this issue Nov 20, 2023
@indigoxela
Issue #54: Strip tags from image validation messages for notifications
6b6f6d4
@indigoxela indigoxela mentioned this issue Nov 20, 2023
Merged
@indigoxela
Copy link
Member Author

Super simple fix, actually.

indigoxela added a commit that referenced this issue Nov 20, 2023
@indigoxela
Issue #54: Strip tags from image validation messages for notifications (
1eaad3f 
#55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #54: Strip tags from image validation messages for notifications backdrop-contrib/tinymce
1 participant
@indigoxela