Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not remove figure that contain anything #52

Closed
indigoxela opened this issue Nov 20, 2023 · 1 comment · Fixed by #53
Closed

Do not remove figure that contain anything #52

indigoxela opened this issue Nov 20, 2023 · 1 comment · Fixed by #53

Comments

@indigoxela
Copy link
Member

Currently the backdrop image plugin does a quite harsh cleanup with figure:

https://github.com/backdrop-contrib/tinymce/blob/1.x-1.x/js/plugins/backdropimage/plugin.js#L69C31-L69C31

It removes any figure, that doesn't contain any image.

But it's valid that figure contains any flow content, not just images, so better not rip out?
indigoxela added a commit that referenced this issue Nov 20, 2023
@indigoxela
Issue #52: Do not remove figure with content
a33c95f
@indigoxela indigoxela mentioned this issue Nov 20, 2023
Merged
@indigoxela
Copy link
Member Author

indigoxela commented Nov 20, 2023 •
edited
Loading

Seems like CKE 4 and 5 also play nicely when toggling.

See #53

indigoxela added a commit that referenced this issue Nov 20, 2023
@indigoxela
Issue #52: Do not remove figure with content (#53)
61126ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #52: Do not remove figure with content backdrop-contrib/tinymce
1 participant
@indigoxela