Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multivalue fields with editor attached and AJAX #37

Closed
indigoxela opened this issue Nov 8, 2023 · 4 comments · Fixed by #38
Closed

Multivalue fields with editor attached and AJAX #37

indigoxela opened this issue Nov 8, 2023 · 4 comments · Fixed by #38

Comments

@indigoxela
Copy link
Member

Oops, didn't test that before, but currently in multifields the latest changes on editor content are lost, when adding another editor-attached field (via AJAX).

There's a command for that, though, let's see...

@indigoxela
Copy link
Member Author

indigoxela commented Nov 8, 2023

Wow, that's a one-liner.

However, reordering can also happen. And that's also feasible.

@indigoxela indigoxela changed the title Multivalue fields with editor attached and AJAX adding fields Multivalue fields with editor attached and AJAX Nov 8, 2023
@indigoxela indigoxela reopened this Nov 11, 2023
@indigoxela
Copy link
Member Author

indigoxela commented Nov 11, 2023

Reopening this, as there's a related issue in core now: backdrop/backdrop-issues#6287

It might be, that the change related to trigger "move" should get reverted.

Edit: exactly that, this part gets obsolete, when fixed in core: https://github.com/backdrop-contrib/tinymce/blob/1.x-1.x/js/tinymce-integration.js#L117

@indigoxela
Copy link
Member Author

To prevent a conflict with a solution in core for the multifield editor attach/detach problem, better revert before it gets released.

It's an edge case, anyway, and things are also broken for other editor modules, including CKE4 in core.

@indigoxela
Copy link
Member Author

The related core fix has been merged (not released yet), so there's nothing left to do here. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant