Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not insert an empty img tag via image dialog #119

Closed
indigoxela opened this issue Jul 2, 2024 · 1 comment · Fixed by #120
Closed

Do not insert an empty img tag via image dialog #119

indigoxela opened this issue Jul 2, 2024 · 1 comment · Fixed by #120
Labels
type - bug report Something isn't working

Comments

@indigoxela
Copy link
Member

Not new, but so far I never realized, that.

Steps to reproduce:

  • Add an image via image dialog
  • With that image active, open the dialog again
  • Remove the image via "Remove" button inside dialog
  • Hit the dialog's "Insert" button

This results in the image tag to end up like <img alt="" width="" height="" data-align="none"> - without src attribute. That's a bit odd. Actually, I'd rather expect that the img tag gets removed then.

@indigoxela indigoxela added the type - bug report Something isn't working label Jul 2, 2024
@indigoxela
Copy link
Member Author

indigoxela commented Jul 2, 2024

If one just hits the "Insert" button in the dialog without selecting any image, there's currently also an empty img tag. Also with figure/caption or link around it.

@indigoxela indigoxela changed the title Removing an image inside dialog can lead to empty image tag Do not insert an empty img tag via image dialog Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type - bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant