-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiny dialog styles vs. Backdrop dialog styles #112
Comments
indigoxela
added a commit
that referenced
this issue
Jun 18, 2024
indigoxela
added a commit
that referenced
this issue
Jun 18, 2024
Reopening this, as adding to body isn't ideal - especially the way it's done.
On the other hand, if adding to some closer parent element, the class gets pointless for dialog theming... |
indigoxela
added a commit
that referenced
this issue
Jun 25, 2024
indigoxela
added a commit
that referenced
this issue
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have two completely different dialog types. Those created via TinyMCE API and those provided from Backdrop (jQuery.ui actually, but styled differently).
They'll never look the same, but could be more similar.
The tricky part: Backdrop themes set different styles, Tiny skins set different styles... 🤪 A theme could override everything to let them look the same, but a module can't do that.
But we could prepare it a bit...
The text was updated successfully, but these errors were encountered: