Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to tiny's built-in loading animation #108

Closed
indigoxela opened this issue Jun 15, 2024 · 0 comments · Fixed by #109
Closed

Switch to tiny's built-in loading animation #108

indigoxela opened this issue Jun 15, 2024 · 0 comments · Fixed by #109

Comments

@indigoxela
Copy link
Member

indigoxela commented Jun 15, 2024

That code part (Backdrop.tinymce.openDialog) has been (mostly) copied from CKE4, but I don't think that delayed throbber animation thing ever worked.
Even with CKE4 it never appears. Neither with CKE5.

However, while working on tinymce_filelink, I discovered TinyMCE's nice and easy to use loading animation. And it actually works. And prevents additional clicks on editor elements, while ajax dialogs are loading.
Very useful for impatient users with slow internet connections. 😉 Gives some feedback, that something happens in background.

And it's time, anyway, to clean up that copy-paste mess in tinymce-integration.js

@indigoxela indigoxela changed the title Switch to tiny's loading animation Switch to tiny's built-in loading animation Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant