New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link plugin (dialog) ignores overridden text #106

Closed

indigoxela opened this issue Jun 13, 2024 · 1 comment · Fixed by #107

Member

indigoxela commented Jun 13, 2024

Inserting works as expected, but overriding is tricky.

When changing the text inside the dialog (e.g. fixing a typo), the new text is discarded. This is not as it's expected to be.

Member Author

indigoxela commented Jun 13, 2024

Oops, that's childNodes vs. children.
Easy to fix, though.

indigoxela added a commit that referenced this issue


          Issue #106: Link plugin (dialog) ignores overridden text

399e265

indigoxela mentioned this issue

Issue #106: Link plugin (dialog) ignores overridden text #107

Merged

indigoxela added a commit that referenced this issue


          Issue #106: Link plugin (dialog) ignores overridden text (#107)

a545b11

indigoxela closed this as completed in #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment