Issue #125: Selecting a linked image should activate both buttons

backdrop-contrib · Jul 18, 2024 · aef8eab · aef8eab
1 parent 62a8a3e
commit aef8eab
Showing 1 changed file with 1 addition and 13 deletions.
diff --git a/js/plugins/backdroplink/plugin.js b/js/plugins/backdroplink/plugin.js
@@ -136,7 +136,7 @@
         editor.on('SelectionChange', function () {
           let node = editor.selection.getNode();
           // The anchor plugin marks its links as not editable.
-          if (node.nodeName === 'A' && node.isContentEditable) {
+          if (node.isContentEditable && (node.nodeName === 'A' || node.parentNode.nodeName === 'A')) {
             api.setActive(true);
           }
           else {
@@ -151,18 +151,6 @@
       onAction: function () {
         editor.execCommand('unlink');
       },
-      onSetup: function (api) {
-        api.setEnabled(false);
-        editor.on('SelectionChange', function () {
-          let node = editor.selection.getNode();
-          if (node.nodeName === 'A' || node.parentNode.nodeName === 'A') {
-            api.setEnabled(true);
-          }
-          else {
-            api.setEnabled(false);
-          }
-        });
-      }
     });
 
     editor.ui.registry.addMenuItem('backdroplink', {