Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using an icon font (fontawesome) for icons. #6

Closed
jenlampton opened this issue Feb 5, 2016 · 4 comments
Closed

Switch to using an icon font (fontawesome) for icons. #6

jenlampton opened this issue Feb 5, 2016 · 4 comments

Comments

@jenlampton
Copy link
Member

Finding open-source icons for various platforms is a long-standing issue for this module. I'd like to switch to using an icon font (specifically font-awesome) so that all the icons that are available there are also available here.
@ghost
Copy link

ghost commented Sep 19, 2017

You could depend on the Font Awesome module...

@jenlampton
Copy link
Member Author

jenlampton commented Sep 19, 2017 •
edited
Loading

I'd thought of that, but I generally dislike dependency chains. Maybe check for the module, and if not there, load fontawesome from CDN?

@ghost
Copy link

ghost commented Sep 19, 2017

That'd work.

@ghost ghost mentioned this issue Sep 19, 2017
Merged
@ghost
Copy link

ghost commented Sep 19, 2017

There you go!

jenlampton pushed a commit that referenced this issue Dec 29, 2017
Issue #6 by BWPanda: Use font-awesome for icons. Remove images.
1d505b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jenlampton