Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin menu #7

Closed
Tracked by #36
laryn opened this issue Jun 16, 2023 · 11 comments · Fixed by #10
Closed
Tracked by #36

Admin menu #7

laryn opened this issue Jun 16, 2023 · 11 comments · Fixed by #10

Comments

@laryn
Copy link
Member

laryn commented Jun 16, 2023

  1. On very small widths, the menu doesn't fully collapse into mobile mode and obscures the page.
  2. I wonder if we might be able to provide the current menu (roughly equivalent to "Horizontal, Modern Toolbar") and a vertical version of the same (roughly equivalent to "New Drupal Navigation, Test integration")

CleanShot 2024-01-09 at 22 44 32@2x

@laryn laryn linked a pull request Jun 19, 2023 that will close this issue
@laryn laryn closed this as completed in #10 Jun 19, 2023
laryn added a commit that referenced this issue Jun 19, 2023
Fixes #7.
Uses Google Material icons.
@laryn
Copy link
Member Author

laryn commented Jun 27, 2023

Re-opening after reverting the name to Gin.

@laryn laryn reopened this Jun 27, 2023
@saschaeggi
Copy link
Collaborator

Added initial styling in f6a93ef

@laryn
Copy link
Member Author

laryn commented Aug 1, 2023

If we are interested in providing the same options as Gin for Drupal has in terms of the menu settings/orientation, perhaps it could be dependent on and integrate with the Navbar module: https://backdropcms.org/project/navbar

@laryn
Copy link
Member Author

laryn commented Jan 10, 2024

I wonder if we might be able to provide the current menu (roughly equivalent to "Horizontal, Modern Toolbar") and a vertical version of the same (roughly equivalent to "New Drupal Navigation, Test integration")

CleanShot 2024-01-09 at 22 44 32@2x

@laryn laryn mentioned this issue Jan 10, 2024
16 tasks
laryn added a commit that referenced this issue Mar 28, 2024
@laryn
Copy link
Member Author

laryn commented Mar 28, 2024

I'm adding a bit of an overhaul to the default admin menu which strips out the core admin menu styles and pulls back in with a lot of it stripped out (background images, colors, etc.)

CleanShot 2024-03-28 at 12 28 59@2x

CleanShot 2024-03-28 at 12 29 21@2x

2725523

@olafgrabienski
Copy link
Member

Looks nice ... as long as I don't switch to the frontend! Is this already supposed to work with Tonic?

@laryn
Copy link
Member Author

laryn commented Apr 2, 2024

Is this already supposed to work with Tonic?

Hopefully soon!

@klonos
Copy link
Member

klonos commented Jul 15, 2024

@laryn the title of this issue is generic and the original screenshot added to the issue summary is broken/missing. Can you please clarify the goals/scope of this issue when you get a chance?

@laryn
Copy link
Member Author

laryn commented Jul 15, 2024

@klonos At this point it's to assess whether we can offer an additional option that is more like one of the vertical options provided in Drupal. And I just noticed on very small widths the menu misbehaves.

@klonos
Copy link
Member

klonos commented Jul 15, 2024

Thanks for taking the time to clarify @laryn 🙏🏼 ...do you mind if we update the issue title to reflect that, or prefer to leave it generic/vague for now?

@laryn
Copy link
Member Author

laryn commented Jul 15, 2024

@klonos I decided to break these into their own issues and consider this early-in-the-porting-process issue as complete.

See:

@laryn laryn closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants