Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical node tabs in References Dialog modal not accessible #151

Closed
olafgrabienski opened this issue Sep 20, 2024 · 4 comments · Fixed by #152
Closed

Vertical node tabs in References Dialog modal not accessible #151

olafgrabienski opened this issue Sep 20, 2024 · 4 comments · Fixed by #152
Labels
bug Something isn't working

Comments

@olafgrabienski
Copy link
Member

Using the beta-6 release, in a modal powered by References Dialog only the first vertical node tab is accessible. Other tabs are visible but not accessible / clickable.

Screenshot:

@olafgrabienski olafgrabienski added the bug Something isn't working label Sep 20, 2024
@olafgrabienski
Copy link
Member Author

Maybe related to changes made for #114?

@laryn
Copy link
Member

laryn commented Sep 24, 2024

@olafgrabienski Could you test this PR and let me know if it's any better for you?
#152

@olafgrabienski
Copy link
Member Author

@laryn Thanks for the PR! At first sight, it doesn't make any difference regarding the issue. The vertical tabs (fieldsets in Gin) are still not accessible.

The PR looks quite big, by the way. Does it address other issues as well? Maybe a smaller fix could do the job here. Using the dev tools code inspector, I see that the following CSS prevents the fieldset content from showing up:

.js fieldset.collapsed .fieldset-wrapper {
  display: none;
}

Example fieldset:

<fieldset class="node-form-author collapsible collapsed form-wrapper" id="edit-author">
  <legend><span class="fieldset-legend">Authoring information</span></legend>
  <div class="fieldset-wrapper">
    <div class="form-item form-type-textfield form-item-name">
      <label for="edit-name">Authored by </label>
      <input type="text" id="edit-name" (...)>
      <input type="hidden" (...)>
    <div class="description">Leave blank for <em class="placeholder">Anonymous</em>.</div>
  </div>
  (...)
</fieldset>

@olafgrabienski
Copy link
Member Author

Thanks, @laryn – I confirm this is fixed using the current release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants