Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #42. Fix php 8.1 incompatibility and exclude flag-defined actions from custom action creation #45

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Issue #42. Fix php 8.1 incompatibility and exclude flag-defined actions from custom action creation #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion includes/flag/flag_flag.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,7 +1283,10 @@ class flag_flag {
function get_valid_actions() {
$actions = module_invoke_all('action_info');
foreach ($actions as $callback => $action) {
if ($action['type'] != $this->entity_type && !in_array('any', $action['triggers'])) {
// Filter actions by needed type, and exclude all actions defined by flag
// itself, since these should not be triggered by the flag module.
// See https://github.com/backdrop-contrib/flag/issues/42
if ($action['type'] != $this->entity_type || in_array($callback, array('flag_node_action', 'flag_comment_action', 'flag_user_action'))) {
unset($actions[$callback]);
}
}
Expand Down