Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing session_api_available() call #26

Closed
laryn opened this issue Jun 18, 2021 · 1 comment
Closed

Removing session_api_available() call #26

laryn opened this issue Jun 18, 2021 · 1 comment
Labels

Comments

@laryn
Copy link
Member

laryn commented Jun 18, 2021

In a separate thread aross states that his previous patch includes an unnecessary call to session_api_available() which can prevent flag from working with anonymous users (and session_api):

I already did some patching of session API, and what will happen now is that the module will attempt to start the session anyway (when get_sid is called). Actually, calling code shouldn't have to use session_api_available() because session_api_get_sid() already does that. I guess I didn't realize that at the time I patched Flag. What will happen is that session API "doesn't work" at the first request, but then tries to set a cookie via $_SESSION. If the client accepts that cookie and sends it with the next request, then Session API works as expected.

It sounds like this module should remove the session_api_available() call completely if I am reading that right.

@herbdool
Copy link
Collaborator

I've removed session_api_available().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants